SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.9.6

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
98 12 0 0

Files

Class Bugs
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLColumnDescription 2
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLNoDataPacket 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.PostgreSQLAggregatedCommandPacket 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLBindCompletePacket 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLComBindPacket 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLStringBinaryProtocolValue 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLUnspecifiedBinaryProtocolValue 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.close.PostgreSQLCloseCompletePacket 2
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLComParsePacket 1
org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLParseCompletePacket 1

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLColumnDescription

Bug Category Details Line Priority
Unread field: org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLColumnDescription.tableOID; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 35 Medium
Unread field: org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLColumnDescription.typeModifier; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 43 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLNoDataPacket

Bug Category Details Line Priority
Public static org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.PostgreSQLNoDataPacket.getInstance() may expose internal representation by returning PostgreSQLNoDataPacket.INSTANCE MALICIOUS_CODE MS_EXPOSE_REP 42 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.PostgreSQLAggregatedCommandPacket

Bug Category Details Line Priority
new org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.PostgreSQLAggregatedCommandPacket(List) may expose internal representation by storing an externally mutable object into PostgreSQLAggregatedCommandPacket.packets MALICIOUS_CODE EI_EXPOSE_REP2 42 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLBindCompletePacket

Bug Category Details Line Priority
Public static org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLBindCompletePacket.getInstance() may expose internal representation by returning PostgreSQLBindCompletePacket.INSTANCE MALICIOUS_CODE MS_EXPOSE_REP 42 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLComBindPacket

Bug Category Details Line Priority
new org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.PostgreSQLComBindPacket(PostgreSQLPacketPayload) may expose internal representation by storing an externally mutable object into PostgreSQLComBindPacket.payload MALICIOUS_CODE EI_EXPOSE_REP2 48 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLStringBinaryProtocolValue

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLStringBinaryProtocolValue.read(PostgreSQLPacketPayload, int): new String(byte[]) I18N DM_DEFAULT_ENCODING 39 High

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLUnspecifiedBinaryProtocolValue

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.bind.protocol.PostgreSQLUnspecifiedBinaryProtocolValue.read(PostgreSQLPacketPayload, int): new String(byte[]) I18N DM_DEFAULT_ENCODING 38 High

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.close.PostgreSQLCloseCompletePacket

Bug Category Details Line Priority
Public static org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.close.PostgreSQLCloseCompletePacket.getInstance() may expose internal representation by returning PostgreSQLCloseCompletePacket.INSTANCE MALICIOUS_CODE MS_EXPOSE_REP 39 Medium
Class (org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.close.PostgreSQLCloseCompletePacket) using singleton design pattern has non-private constructor. CORRECTNESS SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR 27 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLComParsePacket

Bug Category Details Line Priority
new org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLComParsePacket(PostgreSQLPacketPayload) may expose internal representation by storing an externally mutable object into PostgreSQLComParsePacket.payload MALICIOUS_CODE EI_EXPOSE_REP2 50 Medium

org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLParseCompletePacket

Bug Category Details Line Priority
Public static org.apache.shardingsphere.database.protocol.postgresql.packet.command.query.extended.parse.PostgreSQLParseCompletePacket.getInstance() may expose internal representation by returning PostgreSQLParseCompletePacket.INSTANCE MALICIOUS_CODE MS_EXPOSE_REP 42 Medium